BREAKING(encoding): replace Ascii85Options with EncodeAscii85Options and DecodeAscii85Options
#4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4861 +/- ##
==========================================
+ Coverage 92.09% 92.15% +0.05%
==========================================
Files 488 488
Lines 38875 38873 -2
Branches 5398 5400 +2
==========================================
+ Hits 35803 35823 +20
+ Misses 3016 2994 -22
Partials 56 56 ☔ View full report in Codecov by Sentry. |
kt3k
changed the title
Ascii85OptionsAscii85Options
|
Looks like technically a breaking change. Let's land together with |
|
What does this break? |
|
Doesn't |
iuioiua
changed the title
Ascii85OptionsAscii85Options with EncodeAscii85Options and DecodeAscii85Options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change deprecates
Ascii85Optionsin favor ofEncodeAscii85OptionsandDecodeAscii85Options. Previously, these were used for bothencodeAscii85()anddecodeAscii85(), but the latter didn't use thedelimiterproperty.