chore(uuid): release uuid@1.0.0-rc.1
#4867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4867 +/- ##
=======================================
Coverage 92.12% 92.12%
=======================================
Files 487 487
Lines 38745 38745
Branches 5388 5388
=======================================
Hits 35695 35695
Misses 2994 2994
Partials 56 56 ☔ View full report in Codecov by Sentry. |
kt3k
approved these changes
May 29, 2024
|
I'll merge after |
iuioiua
commented
May 31, 2024
| @@ -44,7 +44,7 @@ import { generate as generateV5, validate as validateV5 } from "./v5.ts"; | |||
| * import { assert } from "@std/assert/assert"; | |||
| * | |||
| * const uuid = v1.generate(); | |||
| * assert(v1.validate(uuid)); | |||
| * assert(v1.validate(uuid as string)); | |||
There was a problem hiding this comment.
It seems that when changed, the runtime type-checks this code with a version of @std/uuid prior to the version defined in uuid/deno.json. This appears to be a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4748