Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(net): check scopeid === 0 in getNetworkAddress() #4879

Merged
merged 3 commits into from
May 30, 2024
Merged

fix(net): check scopeid === 0 in getNetworkAddress() #4879

merged 3 commits into from
May 30, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 29, 2024

According to mafintosh/network-address#3 the scopeid needs to be 0 for the address to be reachable if the family is IPv6.

(This is a PR targeting the feature branch, not main)

@kt3k kt3k requested a review from iuioiua May 29, 2024 08:48
@github-actions github-actions bot added the net label May 29, 2024
iuioiua
iuioiua approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to this before me. I added tests that ensure that the return network address is listenable.

@iuioiua iuioiua changed the title fix(net): check scopeid === 0 fix(net): check scopeid === 0 in getNetworkAddress() May 30, 2024
@iuioiua iuioiua merged commit b0be653 into get-network-address May 30, 2024
3 checks passed
@iuioiua iuioiua deleted the get-network-address-check-scope branch May 30, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @iuioiua