Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(crypto): remove KeyStack #4916

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 31, 2024

closes #4909

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.12%. Comparing base (f94f8f3) to head (3cc31bc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4916      +/-   ##
==========================================
- Coverage   92.15%   92.12%   -0.03%     
==========================================
  Files         488      487       -1     
  Lines       38873    38751     -122     
  Branches     5405     5391      -14     
==========================================
- Hits        35823    35699     -124     
- Misses       2994     2996       +2     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Collaborator

iuioiua commented May 31, 2024

Hm... What's with this issue with the Super Doc Linter?

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the issues are fixed.

@kt3k kt3k merged commit 1dd988c into denoland:main May 31, 2024
12 checks passed
@kt3k kt3k deleted the breaking-remove-key-stack branch May 31, 2024 09:03
@iuioiua iuioiua mentioned this pull request Jun 2, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggestion: stabilize KeyStack
2 participants