Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(testing): do not use assertEquals() in snapshot.ts #4930

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 2, 2024

Dependency to assertEquals from testing/snapshot was introduced in #3563 to avoid using non public API of assert from testing (That was necessary for a part of JSR migration).

Now those internal APIs diff, diffStr, and buildMessage are available from std/internal. This PR (partially) reverts #3563 and make testing/snapshot directly use those APIs from std/internal.

This unblocks #4893

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.12%. Comparing base (388800f) to head (a9c712c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4930      +/-   ##
==========================================
- Coverage   92.12%   92.12%   -0.01%     
==========================================
  Files         487      487              
  Lines       38772    38763       -9     
  Branches     5388     5388              
==========================================
- Hits        35719    35710       -9     
  Misses       2997     2997              
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kt3k kt3k merged commit 44bc900 into denoland:main Jun 2, 2024
12 checks passed
@kt3k kt3k deleted the refactor-snapshot branch June 2, 2024 10:28
@iuioiua iuioiua changed the title refactor(testing): do not use assertEquals in snapshot.ts refactor(testing): do not use assertEquals() in snapshot.ts Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants