Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(csv): use assertions in example code snippets #4932

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jun 3, 2024

Fixes current CI issues.

@iuioiua iuioiua requested a review from kt3k as a code owner June 3, 2024 05:27
@github-actions github-actions bot added the csv label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.12%. Comparing base (31b906d) to head (fcf92d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4932   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files         487      487           
  Lines       38771    38771           
  Branches     5388     5388           
=======================================
+ Hits        35716    35718    +2     
+ Misses       2999     2997    -2     
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

csv/_io.ts Outdated Show resolved Hide resolved
csv/_io.ts Outdated Show resolved Hide resolved
csv/csv_stringify_stream.ts Outdated Show resolved Hide resolved
csv/csv_stringify_stream.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua requested a review from kt3k June 3, 2024 05:38
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 7d46b80 into main Jun 3, 2024
12 checks passed
@iuioiua iuioiua deleted the csv-assert-docs branch June 3, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants