Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(url): complete documentation #4965

Merged
merged 2 commits into from
Jun 5, 2024
Merged

docs(url): complete documentation #4965

merged 2 commits into from
Jun 5, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jun 5, 2024

Towards #3764 and #4924

@iuioiua iuioiua requested a review from kt3k as a code owner June 5, 2024 03:20
@github-actions github-actions bot added the url label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.76%. Comparing base (fbfcd24) to head (a843aec).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4965      +/-   ##
==========================================
- Coverage   92.16%   91.76%   -0.40%     
==========================================
  Files         487      487              
  Lines       38740    38741       +1     
  Branches     5393     5359      -34     
==========================================
- Hits        35703    35549     -154     
- Misses       2981     3134     +153     
- Partials       56       58       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

url/dirname.ts Outdated Show resolved Hide resolved
url/extname.ts Show resolved Hide resolved
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

@iuioiua iuioiua enabled auto-merge (squash) June 5, 2024 21:14
@iuioiua iuioiua merged commit b8d9417 into main Jun 5, 2024
10 checks passed
@iuioiua iuioiua deleted the url-docs-complete branch June 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants