refactor(csv): minor cleanups #5158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
commented
Jun 27, 2024
| } | ||
| }, | ||
| transform(chunk, controller) { | ||
| controller.enqueue( | ||
| stringify([chunk], { separator, headers: false, columns }), |
There was a problem hiding this comment.
IIUC, throwing naturally achieves the same result as the previous try/catch block.
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5158 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 473 473
Lines 38056 38044 -12
Branches 5423 5422 -1
=======================================
- Hits 35480 35471 -9
+ Misses 2532 2529 -3
Partials 44 44 ☔ View full report in Codecov by Sentry. |
kt3k
added a commit
to kt3k/deno_std
that referenced
this pull request
Jun 27, 2024
This reverts commit 506439a.
kt3k
added a commit
that referenced
this pull request
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.