Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(yaml): improve parse() testing #5182

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 28, 2024

This PR adds test cases of parse function.

This exercises the case of various escape sequences, invalid strings, yaml directives.

This improves line coverage of yaml package from 60.49% to 65.01%.

part of #3713

@github-actions github-actions bot added the yaml label Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (4052256) to head (ef42f5b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5182      +/-   ##
==========================================
+ Coverage   93.34%   93.77%   +0.43%     
==========================================
  Files         469      469              
  Lines       37917    37917              
  Branches     5386     5449      +63     
==========================================
+ Hits        35392    35557     +165     
+ Misses       2483     2317     -166     
- Partials       42       43       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title test(yaml): improve parse testing test(yaml): improve parse() testing Jun 28, 2024
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kt3k kt3k merged commit de998e7 into denoland:main Jun 28, 2024
16 checks passed
@kt3k kt3k deleted the improve-yaml-test branch June 28, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants