Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(assert,async,bytes,cli,collections,crypto,csv,data-structures,datetime,dotenv,encoding,expect,fmt,front-matter,fs,html,http,ini,internal,io,json,jsonc,log,media-types,msgpack,net,path,semver,streams,testing,text,toml,ulid,url,uuid,webgpu,yaml): import from @std/assert #5199

Merged
merged 3 commits into from
Jun 30, 2024
Merged

refactor(assert,async,bytes,cli,collections,crypto,csv,data-structures,datetime,dotenv,encoding,expect,fmt,front-matter,fs,html,http,ini,internal,io,json,jsonc,log,media-types,msgpack,net,path,semver,streams,testing,text,toml,ulid,url,uuid,webgpu,yaml): import from @std/assert #5199

merged 3 commits into from
Jun 30, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jun 30, 2024 •
edited
Loading

Unblocks #5176 (will result in a cleaner diff). All these imports will be updated after #5176 is merged.

@codecov Codecov
Copy link

codecov bot commented Jun 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (5f2b0f5) to head (6c4c3e0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5199      +/-   ##
==========================================
+ Coverage   94.07%   94.44%   +0.36%     
==========================================
  Files         467      467              
  Lines       37820    37820              
  Branches     5460     5491      +31     
==========================================
+ Hits        35580    35719     +139     
+ Misses       2201     2062     -139     
  Partials       39       39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua mentioned this pull request Jun 30, 2024
Merged
@iuioiua iuioiua marked this pull request as ready for review June 30, 2024 08:14
@kt3k kt3k changed the title refactor: import from @std/assert refactor(assert,async,bytes,cli,collections,crypto,csv,data-structures,datetime,dotenv,encoding,expect,fmt,front-matter,fs,html,http,ini,internal,io,json,jsonc,log,media-types,msgpack,net,path,semver,streams,testing,text,toml,ulid,url,uuid,webgpu,yaml): import from @std/assert Jun 30, 2024
kt3k
kt3k approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua enabled auto-merge (squash) June 30, 2024 08:28
@iuioiua iuioiua merged commit d102a10 into main Jun 30, 2024
15 checks passed
@iuioiua iuioiua deleted the use-std/assert-root branch June 30, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats crowlKats is a code owner

Assignees
No one assigned
Labels
assert async bytes cli collections crypto csv data-structures datetime dotenv encoding expect fmt front-matter fs html http ini internal io json jsonc log media-types msgpack net path semver streams testing text toml ulid url uuid webgpu yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k