Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(expect): improve expect test cases #5221

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 1, 2024

This PR adds test cases of:

  • expect().resolves
  • expect().rejects
  • Throwing cases of custom matchers.

This improves the code coverage of expect about 2%.

part of #3713

@github-actions github-actions bot added the expect label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (d6c3170) to head (ecb79b7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5221      +/-   ##
==========================================
+ Coverage   94.49%   94.59%   +0.10%     
==========================================
  Files         467      467              
  Lines       38143    38143              
  Branches     5494     5502       +8     
==========================================
+ Hits        36042    36082      +40     
+ Misses       2062     2023      -39     
+ Partials       39       38       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

expect/test.ts Show resolved Hide resolved
@kt3k kt3k merged commit 76cf563 into denoland:main Jul 1, 2024
15 checks passed
@kt3k kt3k deleted the improve-expect-testing branch July 1, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants