Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): consolidate yaml/schema/*.ts code into yaml/_schema.ts #5225

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jul 1, 2024

This aims to simplify the code structure of this package.

@iuioiua iuioiua requested a review from kt3k as a code owner July 1, 2024 07:11
@github-actions github-actions bot added the yaml label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 94.72%. Comparing base (90025e9) to head (763adda).

Files Patch % Lines
yaml/_schema.ts 82.08% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5225      +/-   ##
==========================================
- Coverage   94.72%   94.72%   -0.01%     
==========================================
  Files         467      461       -6     
  Lines       38143    38108      -35     
  Branches     5510     5510              
==========================================
- Hits        36131    36096      -35     
  Misses       1974     1974              
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua enabled auto-merge (squash) July 1, 2024 07:25
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit ef71997 into main Jul 1, 2024
15 checks passed
@iuioiua iuioiua deleted the yaml-schema-dir branch July 1, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants