BREAKING(yaml): remove ParseOptions.legacy option
#5229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
changed the title
ParseOptions.legacyParseOptions.legacy option
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5229 +/- ##
==========================================
- Coverage 94.82% 94.82% -0.01%
==========================================
Files 461 461
Lines 38089 38086 -3
Branches 5514 5514
==========================================
- Hits 36118 36115 -3
Misses 1933 1933
Partials 38 38 ☔ View full report in Codecov by Sentry. |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
The
ParseOptions.legacyoption has been removed.Motivation
Setting this option to true allowed documents adhering to versions <1.2 of the YAML specification. v1.2 of the YAML spec was published in 2009 (15 years ago). It's fair to say that most, if not, all, YAML use these days adheres to >=v1.2 of the spec, making this option redundant.
Migration guide
This option only affected those who have the option set to
trueand are adhering to YAML spec version <1.2. If you require this feature, use@std/yaml@0.224.3, as this is the last version containing this feature. Otherwise, we recommend updating your document to use the latest version of the YAML spec.