Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(yaml): inline error functions as methods #5273

Merged
merged 3 commits into from
Jul 3, 2024
Merged

refactor(yaml): inline error functions as methods #5273

merged 3 commits into from
Jul 3, 2024

Conversation

timreichen
Copy link
Contributor

  • inlines throwError() and throwWarning() in LoaderState to avoid passing the state as an argument
  • replaces call(null ...) in throwWarning() with normal function call

@timreichen timreichen requested a review from kt3k as a code owner July 3, 2024 06:32
@github-actions github-actions bot added the yaml label Jul 3, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.17647% with 23 lines in your changes missing coverage. Please review.

Project coverage is 95.74%. Comparing base (ebf8eee) to head (7c2d1ac).

Files Patch % Lines
yaml/_loader.ts 66.17% 23 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5273      +/-   ##
==========================================
+ Coverage   95.70%   95.74%   +0.03%     
==========================================
  Files         458      458              
  Lines       38008    37980      -28     
  Branches     5563     5563              
==========================================
- Hits        36376    36363      -13     
+ Misses       1591     1576      -15     
  Partials       41       41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kt3k
kt3k approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 4f9959d into denoland:main Jul 3, 2024
15 checks passed
@timreichen timreichen deleted the yaml-inline-error-functions branch July 3, 2024 08:40
timreichen added a commit to timreichen/std that referenced this pull request Jul 3, 2024
@timreichen
refactor(yaml): inline error functions as methods (denoland#5273)
4264ae0
iuioiua pushed a commit that referenced this pull request Jul 3, 2024
@timreichen @kt3k
refactor(yaml): add peek() and next() to LoaderState (#5276)
a78d874 
* initial commit

* refactor(yaml): inline error functions as methods (#5273)

* Update _loader.ts

Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>

* refactor(yaml): simplify isWhiteSpaceOrEOL (#5271)

* refactor(yaml): replace `Type` class with interface (#5262)

* update

---------

Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @kt3k