Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fmt): add test cases for printf() #5278

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 3, 2024

part of #3713

This improves the test coverage of fmt/printf.ts from 94.58% to 96.93% (reduces 16 uncovered lines)

@github-actions github-actions bot added the fmt label Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (9127978) to head (e337c58).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5278      +/-   ##
==========================================
+ Coverage   95.72%   95.76%   +0.04%     
==========================================
  Files         457      457              
  Lines       37951    37951              
  Branches     5560     5567       +7     
==========================================
+ Hits        36327    36343      +16     
+ Misses       1583     1567      -16     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title test(fmt): add test cases for printf test(fmt): add test cases for printf() Jul 3, 2024
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kt3k kt3k merged commit cdb6ee4 into denoland:main Jul 4, 2024
16 checks passed
@kt3k kt3k deleted the test-fmt-printf-edge-cases branch July 4, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants