Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(archive): make data property private in Tar #5645

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Aug 6, 2024

This property is not documented or tested anywhere. It seems it was included in the public API by mistake.

@iuioiua iuioiua requested a review from kt3k as a code owner August 6, 2024 15:01
@iuioiua iuioiua enabled auto-merge (squash) August 6, 2024 15:01
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (5e2d065) to head (a4c10c2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5645   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files         468      468           
  Lines       38151    38151           
  Branches     5536     5536           
=======================================
  Hits        36706    36706           
  Misses       1403     1403           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 4432ba1 into main Aug 7, 2024
13 checks passed
@iuioiua iuioiua deleted the archive-data branch August 7, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants