fix(front-matter): remove os specific newline

[timreichen]

Changes
This PR removes the os specific check for \r? before \n.

Reasoning
This is the only occurrence where a os check is done. Even the recognize() function in the same module doesn't do it:

std/front_matter/_shared.ts

Line 36 in 99200dc

const [firstLine] = str.split(/(\r?\n)/) as [string];

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (dea7d77) to head (edc6800).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5752      +/-   ##
==========================================
- Coverage   96.24%   96.23%   -0.01%     
==========================================
  Files         481      481              
  Lines       38751    38749       -2     
  Branches     5618     5617       -1     
==========================================
- Hits        37294    37290       -4     
- Misses       1415     1417       +2     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iuioiua]

The reasoning makes sense to me. But this is definitely not a chore. It's either a breaking change or refactor.

[iuioiua]

Suggested change

	const NEWLINE = "\\r?\\n?";
	const NEWLINE = "\\r?(?:\\n)?";

[timreichen]

I think these brackets don't do anything.

[iuioiua]

Let's merge as-is but keep this suggestion in mind in case anyone runs into any issues.

[kt3k]

I don't think this breaks any existing practical usage as the condition is now more permissive (windows-style new line is now allowed in linux and mac).

How about tagging this as 'fix'?

[iuioiua]

It's more permissive but changes expected behavior depending on the OS, no?

[kt3k]

If we change the parsing behavior depending on the platform, that means the users can't share the exact same markdown files between different platforms (e.g. If windows user creates a markdown file with front-matter with CRLF, then that file can't be parsed in mac/linux). I don't think that meets the expectation of the users.