-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
output directory set to target branch name #540
Comments
Issue is still present in v2 release, and the main branch: https://github.com/npm/agent/actions/runs/9976724284/job/27569631669
|
<!-- What / Why --> <!-- Describe the request in detail. What it does and why it's being changed. --> `steps.metadata.outputs.directory` is set to `/main`, not `/`, when `package.json` is at the root of the repository. I suspect adding `target-branch` to `dependabot.yml` (#330) added a `main` segment to Dependabot PR branch names, which changed the value of `steps.metadata.outputs.directory`. By fixing this issue, we shouldn't need to routinely use stafftools to fix up template-oss Dependabot PRs. 🤞🏼 I couldn't quickly find a `bump @npmcli/template-oss` Dependabot PR for a workspace to inspect `steps.metadata.outputs.directory` and fix workspaces support. If that's important, we may want to either enable Dependabot for `npm/cli` or create a separate `template-oss-test` repo. It's not clear if Dependabot will create a PR for `workspace/test-workspace` upon our next release. ### Example Dependabot PR branch names The first PR updates just `@npmcli/template-oss`. The second updates multiple dependencies including `@npmcli/template-oss`. PR | branch name | segments | steps.metadata.outputs.directory -|-|-|- npm/agent#110 | `dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0` | 5 | `/main` npm/statusboard#877 | `dependabot/npm_and_yarn/main/dependency-updates-4de8b5bfcf` | 4 | `/` ## References <!-- Examples: Related to #0 Depends on #0 Blocked by #0 Fixes #0 Closes #0 --> Failed "Post Dependabot" run: https://github.com/npm/agent/actions/runs/9963674341/job/27530225303 Fix manually tested here: npm/agent@ef85b08 [branchNameToDirectoryName](https://github.com/dependabot/fetch-metadata/blob/ffa2dc8ffecf17d26f6a81b83f9ef5edd33ba93a/src/dependabot/update_metadata.ts#L31) Bug report: dependabot/fetch-metadata#540
I'm sorry, I don't understand the issue as currently described. What is your desired/expected behavior? And what is the current behavior? |
The PR head branch name is incorrectly parsed by branchNameToDirectoryName under some conditions. Expected behaviorThe Actual behaviorThe |
I think the output directory is set to
/{branch-name}
whentarget-branch
is specified independabot.yml
, a single npm dependency is updated, and that dependency is scoped (has two segments).dependabot.yml
with target branch name: https://github.com/npm/agent/blob/21c19874834fb00c7ab37268b385fb84deb2df04/.github/dependabot.ymlExample Dependabot PR branch names
The first PR updates just
@npmcli/template-oss
. The second updates multiple dependencies including@npmcli/template-oss
.outputs.directory
dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0
/main
dependabot/npm_and_yarn/main/dependency-updates-4de8b5bfcf
/
npm/agent
output:npm/statusboard
output:The text was updated successfully, but these errors were encountered: