Skip to content

Commit

Permalink
fix(aria-allowed-attrs): add aria-expanded to allowed attrs for menui…
Browse files Browse the repository at this point in the history
…temcheckbox and menuitemradio (#3994)
  • Loading branch information
smhigley committed Apr 26, 2023
1 parent 55218d4 commit 0f405c6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/standards/aria-roles.js
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ const ariaRoles = {
type: 'widget',
requiredContext: ['menu', 'menubar', 'group'],
requiredAttrs: ['aria-checked'],
allowedAttrs: ['aria-posinset', 'aria-readonly', 'aria-setsize'],
allowedAttrs: ['aria-expanded', 'aria-posinset', 'aria-readonly', 'aria-setsize'],
superclassRole: ['checkbox', 'menuitem'],
accessibleNameRequired: true,
nameFromContent: true,
Expand All @@ -388,7 +388,7 @@ const ariaRoles = {
type: 'widget',
requiredContext: ['menu', 'menubar', 'group'],
requiredAttrs: ['aria-checked'],
allowedAttrs: ['aria-posinset', 'aria-readonly', 'aria-setsize'],
allowedAttrs: ['aria-expanded', 'aria-posinset', 'aria-readonly', 'aria-setsize'],
superclassRole: ['menuitemcheckbox', 'radio'],
accessibleNameRequired: true,
nameFromContent: true,
Expand Down
2 changes: 2 additions & 0 deletions test/integration/rules/aria-allowed-attr/passes.html
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,7 @@
aria-live="value"
aria-owns="value"
aria-relevant="value"
aria-expanded="value"
>
ok
</div>
Expand Down Expand Up @@ -1064,6 +1065,7 @@
aria-live="value"
aria-owns="value"
aria-relevant="value"
aria-expanded="value"
>
ok
</div>
Expand Down

0 comments on commit 0f405c6

Please sign in to comment.