Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate autocomplete appropriate check #2917

Merged

Conversation

clottman
Copy link
Contributor

@clottman clottman commented May 4, 2021

Deprecates autocomplete-appropriate

Closes issue: #2912

@clottman clottman requested a review from a team as a code owner May 4, 2021 19:02
@WilcoFiers WilcoFiers self-requested a review May 12, 2021 16:19
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to Wilco and he mentioned that we should also remove the check from the rule metadata as well. Sorry about that.

@clottman
Copy link
Contributor Author

@straker I'm not sure what you mean by that, would you mind being more specific?

I did notice looking at some other deprecated checks that the impact for the others was 'minor' - it makes sense to me that a deprecated check shouldn't be a severe impact, so I made that change. Can reverse it if that was the wrong call.

@clottman
Copy link
Contributor Author

Ah I think I figured it out! :D

@straker
Copy link
Contributor

straker commented May 17, 2021

Sorry missed the first question. Yes you removed it correctly. As for the impact change I don't think we should do that as the impact is based on user testing. The tests will also need to be updated with the removal of the check as those failures will no longer fail.

@WilcoFiers
Copy link
Contributor

Reviewed for security.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants