Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add matrix node test #4275

Merged
merged 22 commits into from
Dec 18, 2023
Merged

ci: add matrix node test #4275

merged 22 commits into from
Dec 18, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Dec 15, 2023

Adds a matrix test to test running axe-core in all supported node versions. Currently does not test node 4 support as it turns out axe-core does not work in node 4 as we use array.prototype.includes without a polyfill which doesn't exist in node 4. Will make a new pr after this is merged to add that as a fix.

@straker straker marked this pull request as ready for review December 15, 2023 17:49
@straker straker requested a review from a team as a code owner December 15, 2023 17:49
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small questions.

test/node/node.js Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@@ -17,7 +17,7 @@ jobs:
cache: 'npm'
# Workflows are not allowed to edit workflows. As result, we need to prevent Prettier from formatting them.
- name: Prevent workflows from being formatted
run: echo ".github" >> .prettierignore
run: echo ".github" >> .prettierignore && cat .prettierignore
Copy link
Contributor Author

@straker straker Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line wasn't working correctly and was failing the build as the .prettierignore file didn't have a newline character at the end of the file. So instead of appending a new line item this was appending to the end of the last item. Left this in for easier debugging.

node_modules/
doc/api.github

Copy link
Contributor

@dbjorge dbjorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I verified that locally reverting the fix from #4274 results in the new test correctly failing.

@straker straker merged commit 3658df8 into develop Dec 18, 2023
21 checks passed
@straker straker deleted the matrix-tests branch December 18, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants