If the disk does not support hdparm -C, use unknown state #46
Conversation
`hdparm -C` on WD SSD Black SN750 M.2 does not return no output
|
I have a WD_BLACK SN850 that outputs for What is the exact output you get? |
…converted to DriveState.UNKNOWN
On Debian Buster with kernel 4, |
| @@ -194,9 +194,8 @@ def test_getState(self): | |||
| universal_newlines=True, | |||
| ) | |||
| with unittest.mock.patch("hddfancontrol.subprocess.check_output") as subprocess_check_output_mock: | |||
| subprocess_check_output_mock.side_effect = subprocess.CalledProcessError(0, "") | |||
There was a problem hiding this comment.
This side effect should be kept, we are testing that a hdparm error leads to an hddfancontrol.Drive.DriveState.UNKNOWN state.
I suggest (untested):
subprocess_check_output_mock.side_effect = subprocess.CalledProcessError(0, "")
self.assertEqual(self.drive.getState(), hddfancontrol.Drive.DriveState.UNKNOWN)There was a problem hiding this comment.
Fixed. Please re-run the test because most of them failed with error:
coveralls.exception.CoverallsException: Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs
| @@ -244,9 +243,8 @@ def test_isSleeping(self): | |||
| universal_newlines=True, | |||
| ) | |||
| with unittest.mock.patch("hddfancontrol.subprocess.check_output") as subprocess_check_output_mock: | |||
| subprocess_check_output_mock.side_effect = subprocess.CalledProcessError(0, "") | |||
There was a problem hiding this comment.
Same remark as above, and this a test for isSleeping so we should be testing that, not getState.
|
Rebased, squashed and merged separately in f74a475 |
hdparm -Con WD SSD Black SN750 M.2 returns no output.