Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu switch to 20.04 and add patches to minimize GLIBC requirements #446

Merged
merged 5 commits into from
May 3, 2023

Conversation

theofficialgman
Copy link
Contributor

@theofficialgman theofficialgman commented Apr 25, 2023

this PR also relands my previous x86, arm, and arm64 PR with no necessary changes to build other than bumping the version

@theofficialgman
Copy link
Contributor Author

this needs more time to cook to drop the glibc version on all architectures from the mimimum of 2.28 when building on focal back to 2.17 for better compatibility with older linux distros. will look into this later

@theofficialgman theofficialgman marked this pull request as draft April 25, 2023 19:43
@theofficialgman
Copy link
Contributor Author

also @tidy-dev fyi, you just broke support for ubuntu bionic and focal as well as debian buster and bullseye by building on jammy
minimum glibc requirements are now 2.34 in your latest release

@tidy-dev
Copy link
Contributor

@theofficialgman We can ship another version when the Linux fix gets merged. For now, the priority on the current release is bumping Git for consumption by GitHub Desktop that does not support Linux.

@theofficialgman
Copy link
Contributor Author

@tidy-dev this PR updates git as you did in the separate branch, updates to 20.04 from 18.04, and adds patches (inspired by what is done in chromium) to prevent linking to GLIBC 2.28 symbols on 64bit systems when not necessary. This restores support for GLIBC as old as 2.17 on 64bit systems and GLIBC as old as 2.28 on 32bit systems.

it is done and ready for merge. I would like a release to be made as currently these are still blocking issues for arm support in the linux fork of GitHub Desktop until a release is made and becomes available on npm

@theofficialgman theofficialgman mentioned this pull request Apr 25, 2023
@tidy-dev
Copy link
Contributor

This is great! Thank you for working on this so promptly. We have some other priorities in line at the moment. But, I will try to circle back to this within the next few days.

@sergiou87
Copy link
Member

This is exactly the kind of thing I mentioned in #414 (review) 😅

Thanks for taking care of the fix so quickly @theofficialgman !!

@theofficialgman
Copy link
Contributor Author

theofficialgman commented Apr 26, 2023

This is exactly the kind of thing I mentioned in #414 (review) 😅

Thanks for taking care of the fix so quickly @theofficialgman !!

I don't really understand what @tidy-dev ran into when testing. Bumping to 20.04 worked with no changes. Bumping to 22.04 is missing one dependency by default for curl (https://github.com/theofficialgman/dugite-native/actions/runs/4803799489/jobs/8548662518#step:12:1417) but disabling --without-brotli fixes that.

The only changes in the PR have to do with attempting to lower the minimum required GLIBC back to levels near or below bionic. Bumping to 20.04 rather than 22.04 was chosen because keeping the GLIBC version low is much harder when building on 22.04.

@theofficialgman
Copy link
Contributor Author

I will rebase this PR on master shortly.

This reverts commit 887e871.
restores compatibility with distros with GLIBC as low as 2.17 for 64bit systems (x86_64 and arm64)

32bit systems require glibc 2.28+ in order to have functional 2GB+ file support so will require GLIBC 2.28
@theofficialgman theofficialgman changed the title Update Git and Ubuntu from 18.04 -> 20.04 Ubuntu switch to 20.04 and add patches to minimize GLIBC requirements Apr 26, 2023
@theofficialgman
Copy link
Contributor Author

Rebased and ready for merge

@theofficialgman
Copy link
Contributor Author

For now, the priority on the current release is bumping Git for consumption by GitHub Desktop that does not support Linux.

also regarding this. I know you probably can't answer but is there a specific reason why you developers are not allowed to support Linux officially at GitHub Desktop? Some microsoft policy about not supporting linux in general? I am sure you are aware that Linux is a significantly larger platform for developers than MacOS which you do support.

specify minimum GLIBC requirements
@theofficialgman
Copy link
Contributor Author

@tidy-dev are you able to circle back around to this to merge? the changes are really non-existant to build as mentioned here #446 (comment)

@sergiou87 sergiou87 merged commit c3b73df into desktop:master May 3, 2023
@shiftkey shiftkey mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants