Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot locking "as resolved" #7

Closed
batpigandme opened this issue Jun 22, 2018 · 4 comments
Closed

Bot locking "as resolved" #7

batpigandme opened this issue Jun 22, 2018 · 4 comments

Comments

@batpigandme
Copy link

Hi,

Love your probots!

It was just pointed out that the lock bot is locking threads "as resolved" (e.g. see here).
image

Is there a way to reconfigure so it's locking without a reason, as in the example (and as I modified, above)? The lock.yml for that repo is here. I don't think I've configured it specifically for "resolved" anywhere, but could easily be missing something.

Thanks for your help.
Mara
@dessant
Copy link
Owner

dessant commented Jun 22, 2018 •
edited
Loading

Hi! This change was introduced in #3 and it is not configurable at this time. I'm going to add a config option to disable it.

@batpigandme
Copy link
Author

😳 so sorry, thought I searched issues and PRs! Awesome, thanks so much!

@dessant
Copy link
Owner

dessant commented Jun 24, 2018 •
edited
Loading

@batpigandme, please use setLockReason: false to stop setting the locking reason. Thanks for filing this issue, and sorry for the inconvenience. 🐶

@batpigandme batpigandme mentioned this issue Jun 25, 2018
Merged
@batpigandme
Copy link
Author

Awesome! Thanks so much 😊

batpigandme added a commit to batpigandme/ggplot2 that referenced this issue Jun 25, 2018
@batpigandme
Update lockbot reason 🔒🤖
124229d 
* Fixes tidyverse#2713
* Stop lockbot from marking issues as resolved.
* See dessant/lock-threads#7 re. new `setLockReason` param.
* Add lockComment explaining why issue locked.
@batpigandme batpigandme mentioned this issue Jun 25, 2018
Merged
hadley pushed a commit to tidyverse/ggplot2 that referenced this issue Jul 8, 2018
@batpigandme @hadley
Update lockbot reason 🔒🤖 (#2714)
c4b6f51 
* Update lockbot reason 🔒🤖
* Fixes #2713
* Stop lockbot from marking issues as resolved.
* See dessant/lock-threads#7 re. new `setLockReason` param.
* Add lockComment explaining why issue locked.
* Add reprex link
@manoldonev manoldonev mentioned this issue Aug 23, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@batpigandme @dessant