Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

おみくじライブラリを書いた #860

Merged
merged 35 commits into from
Mar 9, 2022
Merged

おみくじライブラリを書いた #860

merged 35 commits into from
Mar 9, 2022

Conversation

fono09
Copy link
Collaborator

@fono09 fono09 commented Mar 5, 2022

#253 の実装を始めた

@fono09 fono09 self-assigned this Mar 5, 2022
@fono09 fono09 marked this pull request as draft March 5, 2022 15:49
@fono09 fono09 changed the title WIP: おみくじライブラリを書いた おみくじライブラリを書いた Mar 5, 2022
@fono09 fono09 changed the title おみくじライブラリを書いた WIP: おみくじライブラリを書いた Mar 5, 2022
@fono09 fono09 changed the title WIP: おみくじライブラリを書いた おみくじライブラリを書いた Mar 5, 2022
fono09 added a commit that referenced this pull request Mar 5, 2022
formatが間違ってたので直してあげたよ!PRをマージしてね! #860
fono09 added a commit that referenced this pull request Mar 5, 2022
formatが間違ってたので直してあげたよ!PRをマージしてね! #860
fono09 added a commit that referenced this pull request Mar 5, 2022
formatが間違ってたので直してあげたよ!PRをマージしてね! #860
fono09 added a commit that referenced this pull request Mar 6, 2022
formatが間違ってたので直してあげたよ!PRをマージしてね! #860
fono09 added a commit that referenced this pull request Mar 6, 2022
formatが間違ってたので直してあげたよ!PRをマージしてね! #860
@fono09 fono09 force-pushed the fono/add-omikuji branch 2 times, most recently from 62d14e1 to f7f4c9b Compare March 6, 2022 01:25
fono09 added a commit that referenced this pull request Mar 6, 2022
formatが間違ってたので直してあげたよ!PRをマージしてね! #860
plugins/hato.py Outdated
),
OmikujiEnum.HATO_KICHI: OmikujiResult(
2,
":dove_of_peace: 鳩吉 お前が鳩になる番だ!!羽ばたけ!!!飛べ!!!!唐揚げになれ!!!!!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issueの要件では揚げ吉では?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

揚げ吉いれました

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

どんなレビューだよw

@fono09 fono09 force-pushed the fono/add-omikuji branch 2 times, most recently from e062cb9 to fcdb8bd Compare March 9, 2022 13:47
nakkaa
nakkaa previously approved these changes Mar 9, 2022
@fono09 fono09 force-pushed the fono/add-omikuji branch 3 times, most recently from 537c500 to f8417cb Compare March 9, 2022 13:57
@nakkaa
Copy link
Member

nakkaa commented Mar 9, 2022

Slackで動くか試験した?

@nakkaa nakkaa temporarily deployed to hatbot March 9, 2022 14:12 Inactive
Copy link
Member

@nakkaa nakkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動いてるからよし

@fono09 fono09 merged commit 5b06428 into develop Mar 9, 2022
@fono09 fono09 deleted the fono/add-omikuji branch March 9, 2022 14:17
@Goryudyuma
Copy link
Member

すご、全部解決してるじゃん!
ここだけ無駄に?最高に?型安全!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants