fix: improve cjs esm compatibility #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this fix #44 as well do you think? |
Yes, this PR also resolves that issue. There was another issue now Thank you for making me aware of that, it helped me catch the bug 👍 . |
|
I also fixed a wrong import in tests and small lint issue that was introduced by me. Now it should be better. |
|
@developit When you get the time, please check out the PR as it should resolve quite a lot of issues. |
|
Possibly a fix for #48 too |
|
The build is broken for 7 months in this PR isn't reviewed after 4 months. Maybe time to fork this 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #46 and also #36 and #44