fix(github-actions): improve error logging and fix ESM node resolution

We recently prioritized `module` over `main` but this results in browser
code being prioritized sometimes. We revert that change and keep the
original/default ESBuild main field order.

This unveils an issue with `jsonc-parser` though- which ships an UMD
file for `main` that cannot be bundled. We can work around this by
processing `jsonc-parser`'s ESM output directly and then using that
instead of leaving resolution to ESBuild for this package.

There is an issue for this being tracked: microsoft/node-jsonc-parser#57

bazel/esbuild/index.bzl

@@ -29,7 +29,6 @@ def esbuild_esm_bundle(name, **kwargs):
 
     args = dict(
         resolveExtensions = [".mjs", ".js", ".json"],
-        mainFields = ["module", "main"],
         outExtension = {".js": ".mjs"},
         # Workaround for: https://github.com/evanw/esbuild/issues/1921.
         banner = {

github-actions/commit-message-based-labels/lib/main.ts

@@ -93,7 +93,7 @@ class CommitMessageBasedLabelManager {
 // to prevent the action from actually running in a fork of a repository with this action set up.
 if (context.repo.owner === 'angular') {
   CommitMessageBasedLabelManager.run().catch((e: Error) => {
-    core.error(e);
+    console.error(e);
     core.setFailed(e.message);
   });
 } else {

github-actions/create-pr-for-changes/lib/main.ts

@@ -201,7 +201,7 @@ async function main(): Promise<void> {
     }
   } catch (err: any) {
     core.setOutput('result', ActionResult.failed);
-    core.error(err);
+    console.error(err);
     core.setFailed(err.message);
   }
 }

github-actions/google-internal-tests/lib/main.ts

@@ -97,6 +97,6 @@ async function findExistingTestStatus(
 }
 
 main().catch((e: Error) => {
-  core.error(e);
+  console.error(e);
   core.setFailed(e.message);
 });

github-actions/lock-closed/lib/main.ts

@@ -115,7 +115,7 @@ async function runLockClosedAction(github: Octokit): Promise<void> {
 // Runs triggered via 'workflow_dispatch' are also allowed to run.
 if (context.repo.owner === 'angular' || context.eventName === 'workflow_dispatch') {
   main().catch((e: Error) => {
-    core.error(e);
+    console.error(e);
     core.setFailed(e.message);
   });
 } else {

github-actions/post-approval-changes/lib/main.ts

@@ -136,7 +136,7 @@ async function runPostApprovalChangesAction(client: Octokit): Promise<void> {
 // Runs triggered via 'workflow_dispatch' are also allowed to run.
 if (context.repo.owner === 'angular') {
   main().catch((e: Error) => {
-    core.error(e);
+    console.error(e);
     core.setFailed(e.message);
   });
 } else {

github-actions/slash-commands/lib/main.ts

@@ -121,7 +121,7 @@ async function runSlashCommandsAction(
 // to prevent the action from actually running in a fork of a repository with this action set up.
 if (context.repo.owner === 'angular') {
   main().catch((e: Error) => {
-    core.error(e);
+    console.error(e);
     core.setFailed(e.message);
   });
 } else {

ng-dev/caretaker/BUILD.bazel

@@ -8,9 +8,9 @@ ts_library(
         "//ng-dev:__subpackages__",
     ],
     deps = [
+        "//tools/esm-interop:jsonc-parser",
         "@npm//@types/minimatch",
         "@npm//@types/node",
-        "@npm//jsonc-parser",
         "@npm//minimatch",
     ],
 )

ng-dev/caretaker/g3-sync-config.ts

@@ -8,7 +8,7 @@
 
 import minimatch from 'minimatch';
 import fs from 'fs';
-import * as jsonc from 'jsonc-parser';
+import * as jsonc from '../../tools/esm-interop/jsonc-parser.js';
 
 /** Configuration describing how files are synced into Google. */
 export interface GoogleSyncConfig {

test.js

@@ -0,0 +1,4 @@
+/**
+ * @fileoverview Description of this file.
+ */
+console.error(crypto);

tools/esm-interop/BUILD.bazel

@@ -0,0 +1,21 @@
+load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
+load("//tools:defaults.bzl", "esbuild")
+
+package(default_visibility = [
+    "//github-actions:__subpackages__",
+    "//ng-dev:__subpackages__",
+])
+
+esbuild(
+    name = "jsonc_parser_bundle",
+    entry_point = "@npm//:node_modules/jsonc-parser/lib/esm/main.js",
+    output = "jsonc-parser.js",
+    deps = ["@npm//jsonc-parser"],
+)
+
+# Workaround for: https://github.com/microsoft/node-jsonc-parser/issues/57.
+js_library(
+    name = "jsonc-parser",
+    srcs = ["jsonc-parser.d.ts"],
+    deps = [":jsonc_parser_bundle"],
+)

tools/esm-interop/jsonc-parser.d.ts

@@ -0,0 +1 @@
+export * from 'jsonc-parser';