Resolve 2011 #2040
Merged
Resolve 2011 #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another bug than 2012: on.on('populate') executes within 'versionchange' transaction and not normal 'readwrite' transaction.
The result was that our "mutate" override added the optimistic updates but the "transaction" override didn't follow up on these optimistic updates because it only follows up on "readwrite" transactions so it left them hanging there forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2011 was another bug than #2012.
Its repro uses on.on('populate') to add objects.
Bug: The 'populate' event executes within 'versionchange' transaction and not normal 'readwrite' transaction.
Our cache is implemented using Dexie.use() middleware that overriders "transaction", "mutate" and "query".
The result was that our "mutate" override added the optimistic updates but the "transaction" override didn't follow up on these optimistic updates when the transaction settled because it only follows up on "readwrite" transactions so it left them hanging there forever.