Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses cmp for sortBy #2074

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

genki
Copy link

@genki genki commented Sep 21, 2024

Fixes #2073

@dfahlander
Copy link
Collaborator

Thanks! Good you saw this and fixed. Will however change to use the custom cmp from cmp.ts (because it is faster and doesn't throw when data contains null keys)

@genki
Copy link
Author

genki commented Sep 21, 2024

@dfahlander Okay, I did it :)

@genki genki changed the title Uses indexedDB.cmp for sortBy Uses cmp for sortBy Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection.sortBy doesn't use IndexedDB.cmp for Uint8Array values
2 participants