EES-2938 Remove node-sass and pin sass at 1.32.13
#3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes `node-sass` in favour of `sass` (the Dart implementation) so that we should no longer get node-gyp errors in the build pipeline. Note that we have pinned `sass` at 1.32.13, instead of the latest version due to `govuk-frontend` using deprecated features. This was unfortunately causing too much unnecessary noise in the frontend dev server logs. This should hopefully be resolved by `govuk-frontend` at some point the future. See: alphagov/govuk-frontend#2238
ntsim
requested review from
benoutram,
duncan-at-hiveit,
a user,
luke-h1 and
amyb-hiveit
benoutram
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes
node-sassin favour ofsass(the Dart implementation) so that we should no longer get node-gyp errors in the build pipeline.Note that we have pinned
sassat 1.32.13, instead of the latest version due togovuk-frontendusing deprecated features. This was unfortunately causing too much unnecessary noise in the frontend dev server logs.This should hopefully be resolved by
govuk-frontendat some point the future. See: alphagov/govuk-frontend#2238