Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTS build: don't vendor Rust deps #2829

Closed
wants to merge 3 commits into from
Closed

RTS build: don't vendor Rust deps #2829

wants to merge 3 commits into from

Commits on Oct 6, 2021

  1. RTS build: don't vendor Rust deps 

    Vendoring dependencies is causing a lot of problems in #2761 and other
PRs, because `cargo vendor` currently has a bug and cannot vendor
standard dependencies (deps of alloc and std, see
rust-lang/wg-cargo-std-aware#23).

For a long time I thought vendoring is a necessity and tried to work
around this issue by vendoring dependencies manually, or using
https://github.com/nix-community/naersk.

However, it turns out vendoring is not necessary, and we can download
dependencies in build step just fine. I also don't see any advantages of
vendoring the dependencies. So in this PR we remove vendoring.

Unblocks #2761.
    @osa1
    osa1 committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    22e38e1 View commit details
    Browse the repository at this point in the history

  2. Set CARGO_HTTP_MULTIPLEXING=false

    @osa1
    osa1 committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    02cca73 View commit details
    Browse the repository at this point in the history

  3. Add git as rts dep

    @osa1
    osa1 committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    391a8da View commit details
    Browse the repository at this point in the history