improve n-ary continuation coercion #4615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead call into the new `@coerce_cont`.
ggreif
commented
Jul 14, 2024
src/ir_passes/async.ml
Outdated
| varE r | ||
| ]) | ||
| ) | ||
| varE (var "@coerce_and_cont" (unary_async --> ([k; fail] -->* (varE unary_async -*- tupE [varE unary_fulfill; varE fail])) |> typ)) |
There was a problem hiding this comment.
actually this is for 0-ary continuations (impedance matching to unary, with unit)
Can we improve below?
There was a problem hiding this comment.
Nope, we really get pairs etc., not only unit. Fixing...
There was a problem hiding this comment.
Is there something wrong with the original code? The replacement actually seems way more convoluted. I would revert, tbh.
later I'll generate the rest
ggreif
commented
Jul 15, 2024
| coerce t1 | ||
| begin match T.normalize t1 with | ||
| | T.Tup [] -> | ||
| varE (var "@coerce_and_cont00" coerce_and_cont0T) -*- varE unary_async |
There was a problem hiding this comment.
seems like this case never gets hit
ggreif
commented
Jul 15, 2024
| @@ -66,6 +66,9 @@ actor a { | |||
| Prim.debugPrint a; | |||
| Prim.debugPrint b; | |||
| }; | |||
| Prim.debugPrint (debug_show (await p())); | |||
| Prim.debugPrint (debug_show (await async (1, "two", '3'))); | |||
There was a problem hiding this comment.
I want to exercise the higher tuples too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.