Wait for navigation after staking first neuron #5409
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Before you have your first neuron, you can't navigate to the neurons page.
So the first neuron is staked from the staking page and if successful, you automatically navigate to the neurons page.
This caused some flakiness in e2e tests when we try to navigate back after staking the first neuron, but before the redirect happens.
To make this more consistent we should wait for the redirect to happen before returning from
stakeFirstNnsNeuron
.Since this happens from
StakingPo
, we can't wait forNnsNeuronsPo
to be present but we can at least wait forStakingPo
to be absent.Changes
Wait for
StakingPo
to be absent after staking the first NNS neuron.Tests
On my local machine,
e2e/proposals.spec.ts
was failing consistently without this change and passed with this change.Todos
not necessary