Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for navigation after staking first neuron #5409

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

dskloetd
Copy link
Contributor

@dskloetd dskloetd commented Sep 5, 2024

Motivation

Before you have your first neuron, you can't navigate to the neurons page.
So the first neuron is staked from the staking page and if successful, you automatically navigate to the neurons page.
This caused some flakiness in e2e tests when we try to navigate back after staking the first neuron, but before the redirect happens.
To make this more consistent we should wait for the redirect to happen before returning from stakeFirstNnsNeuron.
Since this happens from StakingPo, we can't wait for NnsNeuronsPo to be present but we can at least wait for StakingPo to be absent.

Changes

Wait for StakingPo to be absent after staking the first NNS neuron.

Tests

On my local machine, e2e/proposals.spec.ts was failing consistently without this change and passed with this change.

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review September 5, 2024 14:17
@dskloetd dskloetd requested a review from a team as a code owner September 5, 2024 14:17
@dskloetd dskloetd added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 33c3e76 Sep 5, 2024
30 checks passed
@dskloetd dskloetd deleted the kloet/staking-absent branch September 5, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants