Load minimum stake when staking from staking table #5413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #5339 we added the staking button to the staking table.
This opens the SNS staking modal via a different code path, which didn't load the SNS parameters.
This meant that the minimum neuron stake wasn't available.
Instead of requiring the minimum stake to be available, the
SnsStakeNeuronModal
component happily ignores this and allows the user to try staking any amount.But if the amount it too small, claiming the neuron after transferring the tokens fails.
This PR makes sure the parameters are loaded.
We should additionally fix
SnsStakeNeuronModal
to require the minimum stake to be present but that will be a separate PR.Changes
Make sure the SNS parameters (which include the minimum stake) are loaded before opening the
SnsStakeNeuronModal
from theStaking
page.Tests
Todos