EIP-4844 #1
Draft
EIP-4844 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgcoffman
commented
Oct 17, 2022
| @@ -136,7 +136,7 @@ describe("LevelDB controller", () => { | |||
|
|
|||
| function getDbSize(): number { | |||
| // 116 ./.__testdb | |||
| const res = execSync(`du -bs ${dbLocation}`, {encoding: "utf8"}); | |||
There was a problem hiding this comment.
-b doesn't exist on OSX's du
3 tasks
dgcoffman
force-pushed
the
dgc/eip-4844
branch
2 times, most recently
from
df8ff46
to
4f8602d
Compare
dgcoffman
commented
Oct 29, 2022
dgcoffman
force-pushed
the
dgc/eip-4844
branch
from
e34a475
to
78220ef
Compare
3 tasks
7 tasks
dgcoffman
commented
Nov 17, 2022
| @@ -38,7 +38,7 @@ export const phase0: Phase0Preset = { | |||
| // 2**0 (= 1) slots 6 seconds | |||
| MIN_ATTESTATION_INCLUSION_DELAY: 1, | |||
| // [customized] fast epochs | |||
| SLOTS_PER_EPOCH: 8, | |||
| SLOTS_PER_EPOCH: 3, | |||
There was a problem hiding this comment.
Don't commit this. Set this way to match https://github.com/Inphi/eip4844-interop/blob/master/prysm/prysm-chain-config.yml#L6
…ine API getBlobsBundle response
…g that will be removed.
…of length 0 and 1
…lication code special-case
…lidateBlobsAndKzgCommitments during block proposing
…lace where it can be imported by other packages. Add back some of the Capella field defaulting
…ash on unexpected parameter type given to blobToKzgCommitment
dgcoffman
force-pushed
the
dgc/eip-4844
branch
from
a7b033b
to
013d173
Compare
dgcoffman
commented
Nov 18, 2022
| @@ -27,7 +28,7 @@ export function validateBlobsAndKzgCommitments( | |||
| // assert [blob_to_kzg_commitment(blob) == commitment for blob, commitment in zip(blobs, blob_kzg_commitments)] | |||
| blobs.forEach((blob, index) => { | |||
| const computedCommitment = blobToKzgCommitment(blob); | |||
| if (computedCommitment !== blobKzgCommitments[index]) { | |||
| if (!typedArraysAreEqual(computedCommitment, blobKzgCommitments[index])) { | |||
There was a problem hiding this comment.
fixed the equality check
dapplion
reviewed
Nov 18, 2022
| } | ||
|
|
||
| // message_offset = 1 + uint32.decode_bytes(opaque_tx[1:5]) | ||
| const messageOffset = 1 + new DataView(opaqueTx.slice(1, 5).buffer, 0).getUint32(0, true); // Should always be 70 |
There was a problem hiding this comment.
This is true, it will always be 70. But for blobVersionedHashOffset I'm not sure if it's always gonna be 283. A blob transaction will:
- Always have a
toaddress. According to the types it can beNone - Always have empty
datafield - Always have empty
access_listfield
If the conditions above hold then it will always be 283
There was a problem hiding this comment.
According to Proto, all three false, https://discord.com/channels/595666850260713488/1031999860997619843/1043315559309250694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements EIP-4844 in Lodestar.
As specified in the consensus specs, except where we are ahead of the spec:
MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTSto 18 days ethereum/consensus-specs#3047See also ethereum/consensus-specs#3043
TODO
See also