Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments in rule filter files #265

Closed
drmfinlay opened this issue Oct 4, 2018 · 3 comments
Closed

Comments in rule filter files #265

drmfinlay opened this issue Oct 4, 2018 · 3 comments
Assignees
@LexiconCode
Labels
Caster Issues pertaining to primarily the Caster project. Documentation Issues related to Documentation
Milestone
v6

Comments

@drmfinlay
Copy link
Member

Hello all. I noticed that both line and in-line comments are supported in filter files, but the docs don't mention it at the moment. Perhaps the Rule Filters section could be changed to mention that?
@LexiconCode LexiconCode added Documentation Issues related to Documentation Caster Issues pertaining to primarily the Caster project. labels Oct 4, 2018
@LexiconCode LexiconCode added this to the v6 milestone Oct 4, 2018
@LexiconCode
Copy link
Member

We should definitely update the docs.

LexiconCode pushed a commit to LexiconCode/Caster that referenced this issue Oct 8, 2018
Documented for Comments in rule filter files dictation-toolbox#265.
01ec0e2 
Added code blocks with Python code formatting.
@LexiconCode LexiconCode mentioned this issue Oct 8, 2018
Merged
@LexiconCode
Copy link
Member

@Danesprite Let me know what you think and I'll close the issue.

@drmfinlay
Copy link
Member Author

Looks good. Yeah, I'll let you know if I notice anything else.

LexiconCode pushed a commit that referenced this issue Oct 9, 2018
Merge pull request #268 from LexiconCode/documentation
80616a5 
Documented python comments are supported in rule filter files #265.
@LexiconCode LexiconCode self-assigned this Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LexiconCode LexiconCode

Labels
Caster Issues pertaining to primarily the Caster project. Documentation Issues related to Documentation
Projects
None yet
Milestone
v6
Development

No branches or pull requests
2 participants
@drmfinlay @LexiconCode