Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change get_name to get_pronunciation to clarify what's being used. #190

Merged

Conversation

betaorbust
Copy link
Contributor

The current use of get_name preferentially returns the pronunciation instead of the name of a rule.
This change updates get_name to be get_pronunciation so the method name is more in line with the underlying logic.

Original:

def get_name(self):
    return self.name if self.pronunciation is None else self.pronunciation

Updated:

def get_pronunciation(self):
    return self.pronunciation if self.pronunciation is not None else self.name

@betaorbust betaorbust changed the base branch from master to develop November 21, 2017 23:13
@synkarius synkarius merged commit ce8b4b0 into dictation-toolbox:develop Nov 23, 2017
@betaorbust betaorbust deleted the disambiguate-get-name--jf branch November 26, 2017 17:43
@LexiconCode LexiconCode added the Enhancement Enhancement of an existing feature label Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants