Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code and JavaScript CCR fixes #195

Merged

Conversation

Versatilus
Copy link
Collaborator

I was looking through the repository of @betaorbust and I thought these commits would be a good fit for the main repository. I see no problem with merging the module for VS Code, but I thought I would seek comments from others on the changes to JavaScript CCR.

I would've just cherry picked the changes for VS Code, but I'm still feeling my way through GitHub and trying to make sure proper attribution is given. Besides, I figured it might be considered rude to merge someone else's work without explicit permission.

@LexiconCode
Copy link
Member

Nice, I was just about to make my own CS Code module. I don't have any opinions on the JavaScript CCR changes.

@betaorbust
Copy link
Contributor

Hey folks,
I'd be super happy to contribute back to the project. I know it's only an ego thing, but if you don't mind too much, I'll put in a PR for these 😄 I've been holding off because it's not a complete set, but I'm entirely up for putting it in now if it'll help people out.

I'll drop one PR for each, so one won't block the other.

@betaorbust
Copy link
Contributor

Oops! I see that you pulled my commits directly! That's awesome -- merge away when you feel ready 😄

@Versatilus Versatilus merged commit 673a9b0 into dictation-toolbox:develop Jan 26, 2018
@Versatilus
Copy link
Collaborator Author

My git-fu is still a bit weak and I'm ultra-paranoid about making sure credit is given properly. I'm trying to proceed cautiously.

This is one of those projects where I get the sense quite a few people fork the repository and start making dramatic customizations. This makes me a little nervous about making sure changes are easy for others to either integrate or ignore.

@LexiconCode LexiconCode added Enhancement Enhancement of an existing feature Grammar Related to a grammar for an application or programming language. labels Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancement of an existing feature Grammar Related to a grammar for an application or programming language.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants