Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial format #201

Merged
merged 4 commits into from
Mar 13, 2018
Merged

Conversation

BazookaMusic
Copy link
Contributor

I have added a partial format command which allows the user to utter any dictation but keep the first n (1 up to 4) words. The rest of the dictation is used as context to improve the accuracy of the first words. Example usage:"single format end of time"=>"end", which minimizes the chances of Dragon actually outputting "and" while at the same time not polluting the command pool with new commands.

…rds, with the rest of the utterance acting as context to increase accuracy
@Versatilus Versatilus changed the base branch from master to develop March 12, 2018 13:26
@Versatilus
Copy link
Collaborator

I'll try to make the extra effort to review this before the end of the day. From a quick glance, I don't expect any problems. I'm just trying to get out of the bad habit of merging without testing. :-)

For future reference, we do all feature enhancements to the develop branch first. I went ahead and changed this pull request for you.

@BazookaMusic
Copy link
Contributor Author

BazookaMusic commented Mar 12, 2018

Thank you I just realized and was going to fix it myself. Just a quick question however, do you have any suggestion for a testing environment where I can test the changes without messing with my main caster installation, because I have made a few other changes to my own installation and for other more complex modifications or additions it won't be so easy to drop them in and test them.
Furthermore, I am not used to git and this is the first project to which I will be contributing, so please excuse my initial clumsiness.

@Versatilus
Copy link
Collaborator

Versatilus commented Mar 12, 2018 via email

@Versatilus
Copy link
Collaborator

Based on the command name, I expected it to behave the same as the other format command, but it doesn't respect preset formatting. Was this intentional?

@BazookaMusic
Copy link
Contributor Author

Whoops, I was trying to imitate the style of the previous code and I chose the master format text function as the template, which doesn't use the global spacing and capitalization. Fixed.

@Versatilus Versatilus merged commit 0acd08a into dictation-toolbox:develop Mar 13, 2018
@Versatilus
Copy link
Collaborator

This is awesome! Thanks!

If you wanted to figure out where to document it, it would be great if you could add a note about the command's use. I've been wanting to rebuild the quick reference with MarkDown, but I haven't gotten around to it.

LexiconCode pushed a commit to LexiconCode/Caster that referenced this pull request Mar 15, 2018
…_format"

This reverts commit 0acd08a, reversing
changes made to 34e477d.
@LexiconCode LexiconCode added Enhancement Enhancement of an existing feature Documentation Issues related to Documentation Known Issue Known issue that has been previously reported. and removed Known Issue Known issue that has been previously reported. labels Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to Documentation Enhancement Enhancement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants