Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "set format" command. #87

Merged
merged 1 commit into from
Aug 15, 2015

Conversation

chilimangoes
Copy link
Collaborator

This PR adds an explicit "set format" command. As discussed in the comments on #86, this allows you to separate the selection of a format from the command used to output formatted text, reducing the number of things you need to say for a single utterance.

Usage example: "set format laws spine bow" followed by "format some identifier".

@chilimangoes
Copy link
Collaborator Author

I'm not partial to using the keyphrase "set format". In fact, I kind of like the idea of using a shorter keyword/keyphrase, like maybe "setti".

synkarius added a commit that referenced this pull request Aug 15, 2015
@synkarius synkarius merged commit 7169045 into dictation-toolbox:master Aug 15, 2015
@synkarius
Copy link
Collaborator

I wanted this in develop rather than master, so I tried checking out your branch and merging into develop, and pushing that, but then Github didn't count you as a contributor. So I reverted that, accepted the pull request to master, reverted my revert, and merged master back into develop. It still isn't counting you as a contributor, and I'm not sure why except that maybe it has to do with your email that you registered on Github with. See the question mark here.

At any rate, my git skills need some sharpening methinks.

@synkarius
Copy link
Collaborator

Also, thank you, this works great and is very useful.

@chilimangoes
Copy link
Collaborator Author

You're welcome. I know what you mean about sharpening your git skills. I use git a lot locally for personal stuff, but working with remote repos, forking, and pull requests still trips me up. :/

I'm not sure how my email would be a problem since I just used my yahoo email to sign up on github. In any case, don't worry about it and thanks for trying. If it keeps happening, I'll look into submitting a support ticket.

@chilimangoes chilimangoes deleted the feature-set-format branch August 27, 2015 21:53
@LexiconCode LexiconCode added Documentation Issues related to Documentation New Feature A new feature that is not currently implemented. labels Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to Documentation New Feature A new feature that is not currently implemented.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants