Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Python 2 longs for max recognitions and in other places #125

Merged
merged 2 commits into from
Aug 22, 2019

Conversation

comodoro
Copy link
Contributor

Using six integer_types

@drmfinlay
Copy link
Member

Thanks! Shouldn't min also allow long arguments?

There are a few other instances of this in dragonfly which I can fix. Are there any reasons to only allow int arguments?

@drmfinlay
Copy link
Member

I've changed the other int type checks I could find with grep. I'll merge this now. Given that longs don't exist in Python 3, I don't see any problem with just using six.integer_types everywhere.

@drmfinlay drmfinlay changed the title Allow long for max recognitions in Python 2 Allow Python 2 longs for max recognitions and in other places Aug 22, 2019
@drmfinlay drmfinlay merged commit fc4eb2d into dictation-toolbox:master Aug 22, 2019
@LexiconCode LexiconCode added the Enhancement Enhancement existing feature label Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancement existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants