Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for the generated doc #3678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

daladim
Copy link

@daladim daladim commented Jul 5, 2023

This adds the Diesel icon on the pages generated by cargo doc.

That's a draft however, because:

  • We may prefer an image that does not include the white "Diesel" text (especially to play nice with the light theme). However, I'm not sure such an image already exists. I could create it, but I'm not sure yet if it would be accepted.
  • I'm not sure the URL I'm pointing to is guaranteed to be always valid in the future. Is it? Should we include e.g. a version number in its URL?

@daladim
Copy link
Author

daladim commented Jul 5, 2023

Here is what the rendered doc now would look like.
(the cannister alone, without the text, would be better aligned imho)

image

@weiznich
Copy link
Member

I think it's fine to assume that the logo stays on the web page for some while. If someone submitts a PR there, we can also host only the logo without the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants