Eclipse-WTP CSS integration #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedtwigg
approved these changes
Oct 23, 2018
There was a problem hiding this comment.
This all looks great to me. My only request is to add prettier support to CssExtension, but that's a feature request, not a bug with this, so I think it's fine to merge and release this as-is. My vote is either:
- merge this as-is and create an issue "Add prettier to CssExtension", and anybody who wants to can add it later
or
- add prettier and then merge
Your call @fvgh, do either as you wish, and I'll cut a release.
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated Eclipse-WTP CSS formatter to Maven and Gradle.
Please have a look at the Gradle sample for details.