Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added targetExclude #353

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Added targetExclude #353

merged 2 commits into from
Feb 12, 2019

Conversation

nedtwigg
Copy link
Member

@nedtwigg nedtwigg commented Feb 10, 2019

Fixes #153, #194, #324.

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

Copy link
Member

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to add tests? Other than that, this LGTM!

@nedtwigg
Copy link
Member Author

Tests is definitely the right answer, and TBF, I would ask for tests if this were from a non-maintainer. But I've got a pretty tight time budget for this project, and the code change is quite small, so I'm gonna merge as-is since we've got a pretty decent hunk of improvements sitting in the changelog.

@nedtwigg nedtwigg merged commit 74d41c8 into master Feb 12, 2019
@nedtwigg nedtwigg deleted the targetExclude branch January 14, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants