Feature/improve test speed #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dleProject(), which correctly sets the user home.
|
Am I right to think that this PR fixes the tests (and speeds them up) by making them all share the same directory for caching dependencies (excluding the one test that uses a different temporary directory)? If so, then it LGTM! 👍 |
Partially. It reduces the number of different directories, but doesn't reduce them all the way to zero. The biggest difference is that we always point to |
…for each resolution. This fixes build problems which have long been a problem on my machine, but haven't shown up on the build server.
…deps (by re-downloading if the cached files have disappeared).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to take a whack at #429.