Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make padded cell mandatory #561

Merged
merged 19 commits into from
May 3, 2020
Merged

Make padded cell mandatory #561

merged 19 commits into from
May 3, 2020

Commits on Apr 30, 2020

  1. Remove paddedCell option throughout Spotless, and deprecate its get… 

    …ters and setters.
    @nedtwigg
    nedtwigg committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    a86e56c View commit details
    Browse the repository at this point in the history

  2. Update documentation for the always-paddedcell future.

    @nedtwigg
    nedtwigg committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    eeb85ba View commit details
    Browse the repository at this point in the history

  3. Fix compile-errors in the "remove paddedcell" adventure.

    @nedtwigg
    nedtwigg committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    ed81aad View commit details
    Browse the repository at this point in the history

  4. Update spotbugs to latest.

    @nedtwigg
    nedtwigg committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    f8ab7ee View commit details
    Browse the repository at this point in the history

  5. Fix tests now that PaddedCell isn't present.

    @nedtwigg
    nedtwigg committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    d4af11f View commit details
    Browse the repository at this point in the history

  6. Refactor PaddedCellBulk's important API into PaddedCell.canonicalIfDirty

    @nedtwigg
    nedtwigg committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    f47d6bb View commit details
    Browse the repository at this point in the history

  7. Improve performance for the common case where PaddedCell is not needed.

    @nedtwigg
    nedtwigg committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    345c519 View commit details
    Browse the repository at this point in the history

  8. Deprecated all of PaddedCellBulk, deleted PaddedCellGradle.

    @nedtwigg
    nedtwigg committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    18719fd View commit details
    Browse the repository at this point in the history

Commits on May 1, 2020

  1. Renamed PaddedCell.canonicalIfDirty to PaddedCell.calculateDirtyState… 

    …(), which now includes info about non-converging steps.
    @nedtwigg
    nedtwigg committed May 1, 2020
    Configuration menu
    Copy the full SHA
    8f54aa1 View commit details
    Browse the repository at this point in the history

  2. Added the spotlessDiagnose task, which does what used to be baked-in … 

    …to spotlessCheck/Apply.
    @nedtwigg
    nedtwigg committed May 1, 2020
    Configuration menu
    Copy the full SHA
    1684d65 View commit details
    Browse the repository at this point in the history

  3. Fix spotbugs warning.

    @nedtwigg
    nedtwigg committed May 1, 2020
    Configuration menu
    Copy the full SHA
    7b81436 View commit details
    Browse the repository at this point in the history

  4. Small change to the PaddedCell.DirtyState API.

    @nedtwigg
    nedtwigg committed May 1, 2020
    Configuration menu
    Copy the full SHA
    df30fdb View commit details
    Browse the repository at this point in the history

  5. Minor changelog improvement.

    @nedtwigg
    nedtwigg committed May 1, 2020
    Configuration menu
    Copy the full SHA
    d8db03f View commit details
    Browse the repository at this point in the history

  6. Update the lib changelog.

    @nedtwigg
    nedtwigg committed May 1, 2020
    Configuration menu
    Copy the full SHA
    9bfdc90 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2020

  1. Improve the padded cell documentation.

    @nedtwigg
    nedtwigg committed May 2, 2020
    Configuration menu
    Copy the full SHA
    b9ac203 View commit details
    Browse the repository at this point in the history

  2. Protect PaddedCell.DirtyState byte[] from user corruption 

    - byte[] canonicalBytes() is now private, and IllegalStateException if called incorrectly
- access to canonicalBytes() is handled by `void writeCanonicalTo(File file)` and `void writeCanonicalTo(OutputStream out)`
    @nedtwigg
    nedtwigg committed May 2, 2020
    Configuration menu
    Copy the full SHA
    8c1a006 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2020

  1. Merge branch 'master' into feat/paddedcell-mandatory

    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    58def19 View commit details
    Browse the repository at this point in the history

  2. Oops! Meant to get the plain OutputStream, not the CORBA one.

    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    5fbf5bb View commit details
    Browse the repository at this point in the history

  3. Revert the spotbugs upgrade.

    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    36a8f97 View commit details
    Browse the repository at this point in the history