Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pass filename to prettier #620

Merged
merged 12 commits into from
Jun 23, 2020
Merged

Feature/pass filename to prettier #620

merged 12 commits into from
Jun 23, 2020

Commits on Jun 20, 2020

  1. add support for prettier to auto-detect parser 

    Based on the name of the currently formatted file, prettier is now able to use different parsers on a filecollection containing mixing resources such as js/html/css and the like by peeking at the actual filename.
    @simschla
    simschla committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    322a292 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2020

  1. also test the filename-detection using a integrationTest

    @simschla
    simschla committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    b148f24 View commit details
    Browse the repository at this point in the history

  2. simplify integration test in gradle and add one in maven

    @simschla
    simschla committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    fcbc706 View commit details
    Browse the repository at this point in the history

  3. add documentation for autodetection of parser

    @simschla
    simschla committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    cac68d3 View commit details
    Browse the repository at this point in the history

  4. add change to "CHANGES.md" files

    @simschla
    simschla committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    08f164d View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. drive-by: make sure npm's correlated node is always first on path

    @simschla
    simschla committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    36a66af View commit details
    Browse the repository at this point in the history

  2. revert opening StepHarness API to support filenames 

    and create a separate instance dedicated to support filenames
    @simschla
    simschla committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    fbfe86c View commit details
    Browse the repository at this point in the history

  3. PR feedback: forwarding to only implementation 

    (and since we already handle the "empty" filename correctly, there is nothing to done)
    @simschla
    simschla committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    4ac63f9 View commit details
    Browse the repository at this point in the history

  4. prevent illegal states by asserting non-null precondition

    @simschla
    simschla committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    1953f8f View commit details
    Browse the repository at this point in the history

  5. StepHarnessWIthFile had too many degrees of freedom. Testing a step d… 

    …epends on:

- the content that gets passed in
- the filename
- the content which is expected

And that's it - there's no filename in and different filename out.  So there should only be 3 arguments, not 4.  Also brought format to be consistent with StepHarness.
    @nedtwigg
    nedtwigg committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    40048d0 View commit details
    Browse the repository at this point in the history

  6. Most of the prettier steps don't depend on the filename, so there's n… 

    …o need to bring in that complexity.
    @nedtwigg
    nedtwigg committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    41214ab View commit details
    Browse the repository at this point in the history

  7. Respect "parser" the same as we respect "filepath"

    @nedtwigg
    nedtwigg committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    fb0390d View commit details
    Browse the repository at this point in the history