Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JsonSimple exception messages #885

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

goughy000
Copy link
Contributor

Hey, just a small PR to improve some of the exception messages when formatting fails in JsonSimple.

Previously the target exception was silently discarded, so you knew a file couldn't be formatted but was up to you to work out why. We now include the target exception as cause so it can appear in stack trace.

Also tweaked the message for the case where we can't determine if the root of the json tree is an object or array.

@nedtwigg nedtwigg merged commit 7028493 into diffplug:main Jul 6, 2021
@goughy000 goughy000 deleted the feature/json-format-cause branch July 6, 2021 21:40
@nedtwigg
Copy link
Member

nedtwigg commented Jul 6, 2021

Thanks! Published in plugin-gradle 5.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants