Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scalafmt 3 support #913

Merged
merged 4 commits into from
Aug 20, 2021
Merged

Added scalafmt 3 support #913

merged 4 commits into from
Aug 20, 2021

Conversation

SimY4
Copy link
Contributor

@SimY4 SimY4 commented Aug 19, 2021

Please make sure that your PR allows edits from maintainers. Sometimes its faster for us to just fix something than it is to describe how to fix it.

Allow edits from maintainers

After creating the PR, please add a commit that adds a bullet-point under the -SNAPSHOT section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and the build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the PR! We definitely need a test showing that this works for 3.x, and maybe we should bump the default version to 3.x as well?

@SimY4 SimY4 force-pushed the main branch 4 times, most recently from 90eb70a to 719aa09 Compare August 20, 2021 03:03
@nedtwigg
Copy link
Member

nedtwigg commented Aug 20, 2021

Perfect! Add changelog entries (all three) and I'll merge and release.

@SimY4 SimY4 requested a review from nedtwigg August 20, 2021 09:57
@nedtwigg nedtwigg merged commit 0d56acd into diffplug:main Aug 20, 2021
@nedtwigg
Copy link
Member

Thanks for the PR! Published in plugin-gradle 5.14.3 and plugin-maven 2.12.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants