Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed dynamic bodies not waking when their joint motor changed #328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gavlig
Copy link

@gavlig gavlig commented May 14, 2022

When wheels on my vehicle stop spinning they might fall asleep in rapier and using motors didnt wake them up so this is my fix

@gavlig gavlig changed the title implemented wake_up_bodies_with_active_motor for impulse joints fixed dynamic bodies not waking when their joint motor changed May 14, 2022
Copy link
Contributor

@Vrixyz Vrixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your report and suggestion for a fix ! Additionally to my comment (for which I do not have a solution to suggest right now), a reproduction / test / example would help with tackling that issue.

In the meantime it should be possible to wake up the body manually.

Comment on lines +209 to +210
/// The flag indicating that motor settings were changed from outside
pub motor_changed: bool,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I appreciate the "low number of lines" this PR ends up, this would add state to an otherwise "configuration" or "data oriented" struct, I'm not sure this is the right place to add that.

@Vrixyz Vrixyz added C-User experience Potential user-experience improvements A-Dynamics P-Medium D-Medium labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Dynamics C-User experience Potential user-experience improvements D-Medium P-Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants